-
Notifications
You must be signed in to change notification settings - Fork 348
feat: added deployment modes section #4731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: added deployment modes section #4731
Conversation
Added info about automatic and manual deployments to both sites
Your Platform.sh environment has successfully deployed. 🚀 See the changed pages: Platform.sh docs |
Adjusted docs according to github comments
made changes suggested in Slack
https://github.com/platformsh/platformsh-docs into 4730-document-the-automaticmanual-deployments-feature
fixed typo
made changes from veronika
added CLI output
removed spaces
added missing word
https://github.com/platformsh/platformsh-docs into 4730-document-the-automaticmanual-deployments-feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the content to clearer instructions.
Co-authored-by: David Bonachera <[email protected]>
made suggested edits
https://github.com/platformsh/platformsh-docs into 4730-document-the-automaticmanual-deployments-feature
added extra command
added subscription to table on upsun docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
### Automatic deployment (default) | ||
|
||
This is the default behavior for all environments. With automatic deployment, changes like code pushes and variable updates are deployed immediately. This type of deployment is best suited for rapid iteration during development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the last sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly? How would you change that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems wrong especially since manual deployments can't actually be enabled on dev environments but only production and staging. So it's more during the initial setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are talking about "Automatic deployment", which is the default behavior. Not manual dpeloyment.
|
||
### Change deployment type | ||
|
||
You can adjust deployment behavior in your environment (staging or production only). To switch to manual, navigate to the environment settings in the Console and select the manual deployments option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to also show how to do it via the CLI and API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI command is several blocks below.
For the API I'm not sure what's the common practice, I feel this page is quite extensive already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add the API in there indeed. I'll add a link for the CLI below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has_staged_activities
is not writable, it's just a helper for the frontend
use upsun environment:deploy:type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gmoigneu @vitolkachova we already have the upsun environment:deploy:type
and platform environment:deploy:type
commands in the docs. Is there anything outstanding surrounding this issue? We also have a tab that addresses how to do this via the API too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well we have a "Change deployment type" where we mention the setting can be changed in the Console. We show the CLI command in the section below, which it's not exactly accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vitolkachova! I was under the impression that the CLI commands were accurate. @davidbonachera could you please let me know if there is something that needs to be changed regarding how users change deployment type via the CLI? It looks like this is the one outstanding thing that needs clarifying before we can merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commands themselves are alright, but the placing might be misleading, otherwise this thread would not be started initially.
Added info about automatic and manual deployments to both sites
Why
Closes #4730
What's changed
/learn/overview/build-deploy.html#automatic-deployment-default now has a deployment modes section.
Where are changes
Updates are for:
sites/platform
templates)sites/upsun
templates)